Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor utils.data module for line count linter #1476

Merged
merged 1 commit into from
Apr 4, 2024
Merged

refactor utils.data module for line count linter #1476

merged 1 commit into from
Apr 4, 2024

Conversation

winglian
Copy link
Collaborator

@winglian winglian commented Apr 4, 2024

The CI was complaining about too many lines in utils/data.py, so refactoring it into more specific modules to workaround that.

@winglian winglian force-pushed the utils-data-refactor branch from 978487e to 84b7be3 Compare April 4, 2024 00:20
@winglian winglian requested a review from NanoCode012 April 4, 2024 13:06
NanoCode012
NanoCode012 approved these changes Apr 4, 2024
View reviewed changes
Copy link
Collaborator

@NanoCode012 NanoCode012 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it's okay. We can maybe start removing some pylint ignores in a separate PR.

@winglian winglian merged commit e0fcef4 into main Apr 4, 2024
8 checks passed
@winglian winglian deleted the utils-data-refactor branch April 4, 2024 23:33
djsaunde pushed a commit that referenced this pull request Dec 17, 2024
@winglian
refactor utils.data module for line count linter (#1476)
af7065e
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@NanoCode012 NanoCode012 NanoCode012 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@winglian @NanoCode012